Closed
Conversation
Owner
|
Thanks for filing this PR and your patience, this is much appreciated! 👏 This PR currently targets two independent features, which makes this rather hard to review (#8 and #12). In particular, I've also started working on #12 a few months ago and ended up implementing Docker's multiplex message stream. Would you mind splitting this up into two independent PRs? |
This was referenced Sep 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No tests included, but I've tested it a bit in my application and seems to work.
I didn't use your
Client::boolArghelper for the stats argument$streambecause the default in Docker API 1.20 is true so if you passedfalseit just would returnNULL(and wouldn't be included in the request).